feat: add createDefaultMetadataKeyInterceptor #2368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 51790ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
BlinkyStitt
force-pushed
the
easier_auth_metadata
branch
from
70b82ee to
f5397a8
Compare
sanjayprabhu
approved these changes
Oct 15, 2024
auto-merge was automatically disabled
October 16, 2024 00:15
Head branch was pushed to by a user without write access
|
I don't see how that test failure could be caused by my change. This function isn't even used. |
sanjayprabhu
approved these changes
Oct 16, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2368 +/- ##
===========================================
- Coverage 74.05% 44.16% -29.90%
===========================================
Files 99 146 +47
Lines 9425 26203 +16778
Branches 2097 9272 +7175
===========================================
+ Hits 6980 11572 +4592
- Misses 2327 12815 +10488
- Partials 118 1816 +1698 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change needed?
Neynar requires x-api-key to access its hubs. This change makes it easy to include that (or any other) header.
I tried to follow the docs to create a changes, but got an error. Am I running it from the wrong directory maybe?
Merge Checklist
Choose all relevant options below by adding an
xnow or at any time before submitting for reviewPR-Codex overview
This PR introduces a new function to create a metadata key interceptor for gRPC calls in the
hub-nodejspackage.Detailed summary
createDefaultMetadataKeyInterceptorfunction inpackages/hub-nodejs/src/client.ts.keyandvalue, returning an interceptor that sets the specified metadata key with the given value if it is not already present.